DM-55171: Add consolidateDiaSourceVisit to ApPipe#276
Conversation
Gerenjie
changed the title
Gerenjie
force-pushed
the
tickets/DM-55171
branch
3 times, most recently
from
367fda6 to
8851aaa
Compare
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
See the comment on re-ordering the new task in ApPipe.yaml, and adding a new contract for the connections.
Also note that consolidateDiaSourceTable needs to be removed from Conversions.yaml and ConversionsForFakes.yaml from ap_verify
| connections.calexp: preliminary_visit_image | ||
| connections.visitSummary: preliminary_visit_summary | ||
| connections.visitSummarySchema: preliminary_visit_summary_schema | ||
| consolidateDiaSourceTable: |
There was a problem hiding this comment.
This task has the output of standardizeDiaSource as its input, so it needs to be moved after that task in the definitions. Also, add a contract to check that the connections.inputCatalogs input connection matches the connections.diaSourceTable output of standardizeDiaSource
Gerenjie
force-pushed
the
tickets/DM-55171
branch
from
8851aaa to
6e98b8d
Compare
|
Is this good to merge? |
|
I marked the PR as |
2 participants
No description provided.